Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plotting of estimates on a log-scale #28

Closed
srison-qmul opened this issue Oct 18, 2022 · 4 comments
Closed

Plotting of estimates on a log-scale #28

srison-qmul opened this issue Oct 18, 2022 · 4 comments
Labels
Next Release To work on for new version release Type: Enhancement

Comments

@srison-qmul
Copy link

At present, the estimates ("r" in the example dataframe) can only be plotted on a linear scale. Certain estimates (e.g. Odds Ratios (ORs)) are typically plotted onto log-scales.
For example, in forestplot:
thumbnail_image
Equivalent in 'R':
image

It would be great if forestplot allowed users the request a log-scale and (ideally) to customize aspects of this.
@LSYS LSYS added Next Release To work on for new version release Type: Enhancement labels Oct 20, 2022
@LSYS
Copy link
Owner

LSYS commented Oct 20, 2022

Thanks for raising this request @srison-qmul.

The next release will allow for log odds.

It seems like the current backend to draw the CIs does not allow for asymmetrical CIs common in ORs. This will have to be changed for the next release too.

@LSYS LSYS mentioned this issue Oct 20, 2022
Closed
@shapiromatron
Copy link
Contributor

I'd love to have this feature too, but I honestly just wanted to drop a note to say I just found this package, really excited to try it out! Thanks for releasing this @LSYS!!!

@srison-qmul
Copy link
Author

srison-qmul commented Oct 21, 2022 via email

LSYS added a commit that referenced this issue Oct 22, 2022
@LSYS
update CI backend (closes #29, #28)
1bf2c10 
update CI backend to mpl ax.errorbar API (closes #29, ref #28)
LSYS added a commit that referenced this issue Oct 22, 2022
@LSYS
remove 'moerror' option (#28, #29)
2b09416 
- making ll and hl default required option for asymmetric CIs (ref #28 & #29)
LSYS added a commit that referenced this issue Oct 30, 2022
@LSYS
Update test_plot.py
3bbf2b6 
- Add logscale option (#28)
LSYS added a commit that referenced this issue Oct 30, 2022
@LSYS
Add logscale option, make no string normalization the default (#34)
3d4f8e9 
* Plotting of estimates on a log-scale #28
* Better backend for Confidence Intervals #29
* Maintain label character formatting (making no string normalisation the default) #27
* Update documentation to reflect new changes and fixing errors #30
@LSYS
Copy link
Owner

LSYS commented Nov 1, 2022

closed in v0.2.0.

@LSYS LSYS closed this as completed Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Next Release To work on for new version release Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@shapiromatron @LSYS @srison-qmul