Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test failure on Mac arm64 #21

Closed
hpages opened this issue Nov 18, 2023 · 5 comments
Closed

Unit test failure on Mac arm64 #21

hpages opened this issue Nov 18, 2023 · 5 comments

Comments

@hpages
Copy link

hpages commented Nov 18, 2023

Looks like BiocNeighbors's unit tests have been failing on Mac arm64 for a while (6 months at least): https://bioconductor.org/checkResults/3.18/bioc-mac-arm64-LATEST/BiocNeighbors/kjohnson1-checksrc.html

As a consequence there's no Mac arm64 binary for the package in BioC 3.18: https://bioconductor.org/packages/3.18/BiocNeighbors

Note that this missing binary is currently blocking the propagation of Mac arm64 binaries for 63 Bioconductor packages that depend directly or indirectly on BiocNeighbors in BioC 3.18.

@LTLA Do you think you could take a look at the unit tests? Hopefully it's just a matter of relaxing the expected floating point precision of the results.

Thanks,
H.

@LTLA
Copy link
Member

LTLA commented Nov 30, 2023

Relaxed by several orders of magnitude, let's see how it goes in 1.21.1.

@hpages
Copy link
Author

hpages commented Dec 12, 2023

Can you please push this to the RELEASE_3_18 branch? The goal is to produce a Mac arm64 binary for the BioC 3.18 release. Our Mac arm64 builder for devel is not ready yet. Thanks!

@LTLA
Copy link
Member

LTLA commented Dec 18, 2023

Done.

@hpages
Copy link
Author

hpages commented Dec 20, 2023

Awesome thanks! Let see what happens on the next build report for kjohnson1 (should be tomorrow, these arm64 Mac builders are super slow and can only build twice a week).

@hpages
Copy link
Author

hpages commented Dec 22, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants