Remove deprecation warnings for rails 6 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LTe
force-pushed
the
deprecation-warning-remove-for-rails-6
branch
from
ca9a1f6
to
4cfa729
Compare
In rails 6 there is deprecation warning for `update_attributes!` method. It will be replaced with `update!` method. In order to remove deprecation I have wrapped method call inside `rails_api` facade.
LTe
force-pushed
the
deprecation-warning-remove-for-rails-6
branch
from
4cfa729
to
dbf7660
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rails 6 there is deprecation warning for
update_attributes!method.It will be replaced with
update!method. In order to removedeprecation I have wrapped method call inside
rails_apifacade.Closes #98