Configurable search scope name #71
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,7 +12,8 @@ module ClassMethods | |||
| def initialize_scopes | |||
| scope :are_from, lambda { |*args| where(:sent_messageable_id => args.first, :sent_messageable_type => args.first.class.name) } | |||
| scope :are_to, lambda { |*args| where(:received_messageable_id => args.first, :received_messageable_type => args.first.class.name) } | |||
| scope :search, lambda { |*args| where("body like :search_txt or topic like :search_txt",:search_txt => "%#{args.first}%")} | |||
| scope ActsAsMessageable.search_scope_name, | |||
| lambda { |*args| where("body like :search_txt or topic like :search_txt",:search_txt => "%#{args.first}%")} | |||
There was a problem hiding this comment.
Line is too long. [142/80]
Align the parameters of a method call if they span more than one line.
Use the new Ruby 1.9 hash syntax.
Space missing after comma.
Space missing inside }.
|
Addresses #62 |
| scope :search, lambda { |*args| where("body like :search_txt or topic like :search_txt",:search_txt => "%#{args.first}%")} | ||
| scope :connected_with, lambda { |*args| where("(sent_messageable_type = :sent_type and | ||
| scope ActsAsMessageable.search_scope_name, | ||
| lambda { |*args| where("body like :search_txt or topic like :search_txt", :search_txt => "%#{args.first}%") } |
There was a problem hiding this comment.
Line is too long. [143/80]
Align the parameters of a method call if they span more than one line.
Use the new Ruby 1.9 hash syntax.
|
Looks like it's still failing. Some pointers or comments on how to improve would be welcome |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add configuration scope name for search to avoid naming conflict