Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add aria label for icon buttons #275

Merged
merged 1 commit into from
Jul 22, 2024
Merged

feat: add aria label for icon buttons #275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/vue/src/components/Input/LuiInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ const computedAttrs = computed(() => {
<span v-if="hasSlotContent(slots.prepend)" :class="prependClasses" class="leading-none">
<slot name="prepend" />
</span>
<button v-if="clear && !attrs.disabled" :class="closeIconClasses" @click="clearInput">
<button v-if="clear && !attrs.disabled" aria-label="Clear input" :class="closeIconClasses" @click="clearInput">
<clearIconTemplate />
</button>
<span v-else-if="!!slots.append" :class="appendClasses">
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/components/Modal/LuiModal.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ function handleOutsideClick(event: any) {
v-bind="$attrs"
>
<div v-if="showIcon" class="float-right leading-3 ml-2">
<LuiButton variant="link" color="secondary" rounded @click="emit('close')">
<LuiButton variant="link" color="secondary" aria-label="close modal" rounded @click="emit('close')">
<span class="sr-only">close modal</span>
<svg width="24" height="24" viewBox="0 0 24 24" fill="none">
<path
Expand Down
2 changes: 1 addition & 1 deletion packages/vue/src/components/Sidebar/LuiSidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ const animationClasses = computed(() =>
@click.stop
>
<div v-if="showIcon" class="float-right leading-3 ml-2">
<LuiButton variant="link" color="secondary" rounded @click="emit('close')">
<LuiButton variant="link" color="secondary" aria-label="close modal" rounded @click="emit('close')">
<span class="sr-only">close modal</span>
<svg width="24" height="24" viewBox="0 0 24 24" fill="none">
<path
Expand Down
Loading