Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided gitian descriptors do not work #20

Closed
osnwt opened this issue Dec 31, 2018 · 8 comments
Closed

Provided gitian descriptors do not work #20

osnwt opened this issue Dec 31, 2018 · 8 comments

Comments

@osnwt
Copy link

osnwt commented Dec 31, 2018

Provided linux binaries use shared libraries. An attempt to build a static version of master branch from the repository using gitian builder has failed since can't find a submodule. It seems there is no such submodule at all by the path.

The gitian builder tested for many coins, so the issue is with Lux descriptors and/or non-standard build sequence (in that case the descriptors must be fixed):

Initialized empty Git repository in /home/debian/gitian-builder/inputs/lux/.git/
remote: Enumerating objects: 161, done.
remote: Counting objects: 100% (161/161), done.
remote: Compressing objects: 100% (110/110), done.
remote: Total 24638 (delta 98), reused 84 (delta 51), pack-reused 24477
Receiving objects: 100% (24638/24638), 155.08 MiB | 5.67 MiB/s, done.
Resolving deltas: 100% (17339/17339), done.
From https://github.com/lux-core/lux
 * [new tag]           v4.3.1                   -> v4.3.1
 * [new tag]           v5.0.0                   -> v5.0.0
 * [new tag]           v5.0.1                   -> v5.0.1
 * [new tag]           v5.0.2                   -> v5.0.2
 * [new tag]           v5.0.3                   -> v5.0.3
 * [new tag]           v5.1.0                   -> v5.1.0
 * [new tag]           v5.2.0                   -> v5.2.0
 * [new tag]           v5.2.1                   -> v5.2.1
 * [new tag]           v5.2.2                   -> v5.2.2
 * [new tag]           v5.2.3                   -> v5.2.3
 * [new tag]           v5.2.5                   -> v5.2.5
 * [new branch]        5.2.X                    -> 5.2.X
 * [new branch]        5.3.X                    -> 5.3.X
 * [new branch]        HDWallet                 -> HDWallet
 * [new branch]        Networking               -> Networking
 * [new branch]        PoS                      -> PoS
 * [new branch]        SPV                      -> SPV
 * [new branch]        TradingPlot              -> TradingPlot
 * [new branch]        backup-master            -> backup-master
 * [new branch]        bip174                   -> bip174
 * [new branch]        btc-0.16                 -> btc-0.16
 * [new branch]        bug_fix                  -> bug_fix
 * [new branch]        bugfix                   -> bugfix
 * [new branch]        coldstake                -> coldstake
 * [new branch]        development              -> development
 * [new branch]        dfs                      -> dfs
 * [new branch]        docker                   -> docker
 * [new branch]        hd_button_encrypted      -> hd_button_encrypted
 * [new branch]        i2p                      -> i2p
 * [new branch]        logrotation              -> logrotation
 * [new branch]        luxgate                  -> luxgate
 * [new branch]        luxgate-fix-sig          -> luxgate-fix-sig
 * [new branch]        luxgate-fix-zmq-undef    -> luxgate-fix-zmq-undef
 * [new branch]        luxgate-global-orderbook -> luxgate-global-orderbook
 * [new branch]        luxgate-qt               -> luxgate-qt
 * [new branch]        luxgate-testing          -> luxgate-testing
 * [new branch]        luxgate-ui               -> luxgate-ui
 * [new branch]        master                   -> master
 * [new branch]        metrics                  -> metrics
 * [new branch]        mining-tests             -> mining-tests
 * [new branch]        p2p-network              -> p2p-network
 * [new branch]        pos-signing              -> pos-signing
 * [new branch]        refactoring              -> refactoring
 * [new branch]        rpc                      -> rpc
 * [new branch]        testing                  -> testing
 * [new branch]        testnet                  -> testnet
 * [new branch]        tests                    -> tests
 * [new branch]        time_drift               -> time_drift
 * [new branch]        topia_keypool_issue      -> topia_keypool_issue
 * [new branch]        tran                     -> tran
 * [new branch]        ubuntu-18.10             -> ubuntu-18.10
 * [new branch]        v6.0.X                   -> v6.0.X
 * [new branch]        web3-api                 -> web3-api
 * [new branch]        win-bug                  -> win-bug
Submodule 'src/lux-installer' (https://github.com/216k155/lux-installer.git) registered for path 'src/lux-installer'
Cloning into '/home/debian/gitian-builder/inputs/lux/src/lux-installer'...
Username for 'https://github.com': git
Password for 'https://git@github.com':
remote: Invalid username or password.
@216k155
Copy link
Contributor

216k155 commented Jan 1, 2019

Hi, osnwt,
The lux-installer submodule (auto-update) is still in close-source on the master branch. We will open source the auto-update in the next release.

@giaki3003
Copy link
Contributor

Working as of 0a34375
Closing

@osnwt
Copy link
Author

osnwt commented Feb 24, 2019

This does not resolve the issue. Gitian builds fail.

Your gitian descriptors still are for lux-2.2, and build silently fails.
Even many shitcoins provide working gitian descriptors, and I wonder why you do not.

Please confirm that your code can create valid static binaries for MacOS, Windows and Linux. Maybe I should update my gitian builder. But I am able to build a lot of coins using it including PIVX, Dash and Bitcoin. But it doesn't work for Lux.

@giaki3003
Copy link
Contributor

Gitian building is being revamped currently. As of now the best way to build is following the instructions provided in this repo, with the dependencies script.

@osnwt
Copy link
Author

osnwt commented Feb 25, 2019

Shouldn't the issue be open then until fixed?

@giaki3003
Copy link
Contributor

The issue you opened was about repo modules being closed to the public, not about gitian not working. Feel free to open a new issue.

@osnwt
Copy link
Author

osnwt commented Mar 2, 2019

The issue I opened has the following subject: Provided gitian descriptors do not work.

I had no idea if you closed some parts of code. Regardless of reason, they do not work being invalid at the moment. So for me the report is correct and must be open until gitian build is fixed.

At the same time I am not a Lux investor, holder or developer. If you don't think that the subject properly reflects the issue, you may open another issue too since Lux team first must be interested to have code clean and buildable. But if you think that the issue is invalid - ok, I see no sense to continue pushing you. Let it stay unfixed and closed.

@giaki3003
Copy link
Contributor

giaki3003 commented Mar 2, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants