-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provided gitian descriptors do not work #20
Comments
Hi, osnwt, |
Working as of 0a34375 |
This does not resolve the issue. Gitian builds fail. Your gitian descriptors still are for lux-2.2, and build silently fails. Please confirm that your code can create valid static binaries for MacOS, Windows and Linux. Maybe I should update my gitian builder. But I am able to build a lot of coins using it including PIVX, Dash and Bitcoin. But it doesn't work for Lux. |
Gitian building is being revamped currently. As of now the best way to build is following the instructions provided in this repo, with the dependencies script. |
Shouldn't the issue be open then until fixed? |
The issue you opened was about repo modules being closed to the public, not about gitian not working. Feel free to open a new issue. |
The issue I opened has the following subject: Provided gitian descriptors do not work. I had no idea if you closed some parts of code. Regardless of reason, they do not work being invalid at the moment. So for me the report is correct and must be open until gitian build is fixed. At the same time I am not a Lux investor, holder or developer. If you don't think that the subject properly reflects the issue, you may open another issue too since Lux team first must be interested to have code clean and buildable. But if you think that the issue is invalid - ok, I see no sense to continue pushing you. Let it stay unfixed and closed. |
I agree Gitian descriptors should be fixed, it's on my ever growing to do
list.
No need to open an issue, I'm aware of this.
Thanks
…On Sat, 2 Mar 2019, 10:35 os, ***@***.***> wrote:
The issue I opened has the following subject: *Provided gitian
descriptors do not work*.
I had no idea if you closed some parts of code. Regardless of reason, they *do
not work* being invalid at the moment. So for me the report is correct
and must be open until gitian build is fixed.
At the same time I am not a Lux investor, holder or developer. If you
don't think that the subject properly reflects the issue, you may open
another issue too since Lux team first must be interested to have code
clean and buildable. But if you think that the issue is invalid - ok, I see
no sense to continue pushing you. Let it stay unfixed and closed.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#20 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AIOilKyrMzcjyFfOCQk8ybXXRt4kfcQ3ks5vSkXhgaJpZM4ZlSGX>
.
|
Provided linux binaries use shared libraries. An attempt to build a static version of master branch from the repository using gitian builder has failed since can't find a submodule. It seems there is no such submodule at all by the path.
The gitian builder tested for many coins, so the issue is with Lux descriptors and/or non-standard build sequence (in that case the descriptors must be fixed):
The text was updated successfully, but these errors were encountered: