Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for model simulation configuration files in INI format in favor of JSON #192

Conversation

soaressgabriel
Copy link
Collaborator

@soaressgabriel soaressgabriel commented Mar 21, 2024

Checklist

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Added tests for changed code.
  • Updated documentation for changed code.

Description

  • Remove *.ini from supported configuration files;
  • Update doc pages to reflect changed code.

Related Issue

Motivation and context

How has this been tested

  • Manual testing was performed by executing RUBEM with provided sample dataset and verifying the output against expected results;
  • Automated tests (unit and integration) must pass without exception.

Screenshots

  • N/A

…n-configuration-files-in-ini-format-in-favor-of-json
Copy link
Collaborator

@LINAMARIAOSORIO LINAMARIAOSORIO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soaressgabriel soaressgabriel merged commit e618597 into main May 14, 2024
7 checks passed
@soaressgabriel soaressgabriel deleted the feature/180-drop-support-for-model-simulation-configuration-files-in-ini-format-in-favor-of-json branch May 14, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for model simulation configuration files in INI format in favor of JSON
2 participants