Send image index on save #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #107, the
CameraBlock sends a signal to downstream Blocks when recording images in case no image processing is performed and output Links are present. Originally, the sent message was containing only the timestamp of the saved image and its metadata. However, these two labels did not allow integration with theSynchronizerBlock added in #108, as the time label is a special one and the metadata label cannot be interpolated.To solve this issue, this PR adds a new label
'index', carrying the image index, to the values sent when saving an image. By taking the'index'label as the reference one for theSynchronizerBlock, is is now possible to synchronize signals with the timestamps of recorded images.