Fix camera configuration bug and remove duplicate code #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids repeating code, and therefore prevents partial fixes in the future.
The error image indicating that no image could be grabbed was being displayed recurrently, whereas it should only be before the very first image is captured. Fixes #113
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As detailed in #113, the camera configuration window currently displays repeatedly an error image in case the Camera object returning the images alternatively returns images or
None. This behavior is not the intended one, as the error image should only be displayed once as the very first frame. In caseNonevalues are received later, the last acquired image should remain in the interface.This PR fixes #113. It also removes duplicate code in children of the camera configuration window class, by using ad-hoc helper functions re-defined by the children classes. As a side-effect, this refactoring propagates the fix of d6247ef to the children classes. Its propagation had been omitted, due to duplicates in code !