Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CameraGphoto2 to existing crappy available cameras #118

Open
wants to merge 32 commits into
base: develop
Choose a base branch
from

Conversation

jeffwitz
Copy link

This is a pull request for the implementation of the DSLR cameras.
It uses the gphoto2 library in order to capture images

@WeisLeDocto WeisLeDocto self-assigned this Mar 21, 2024
@WeisLeDocto
Copy link
Member

WeisLeDocto commented Mar 21, 2024

To make your new Camera object appear in the documentation, you'll need to add it at two separate places in the documentation source files:

You can check locally that the documentation builds as expected, by installing sphinx, as well as the other dependencies listed in docs/source/requirements.txt, and calling the make html directive on the docs/Makefile.
Alternatively, the documentation is automatically built when you push to this pull request, see for example the build for your last commit. This way you can know if anything went wrong.

@jeffwitz
Copy link
Author

I add everything, Do I need to redo, or do you see the changes ?

@WeisLeDocto
Copy link
Member

The documentation couldn't build after your modifications, see the build log for details.

@WeisLeDocto WeisLeDocto linked an issue Apr 14, 2024 that may be closed by this pull request
@WeisLeDocto
Copy link
Member

I made some substantial changes to your code. It contained several lines that needed to be fixed, the overall style and layout could be improved, and the documentation as well. I've been picky as this code for now goes into crappy, I'll surely be less strict for code going directly to crappy.collection once it's implemented.

Can you please double-check that the code still works as expected on one of your cameras ? Once this is confirmed, or the necessary fixes are brought, I can merge this PR.

@jeffwitz
Copy link
Author

I made some substantial changes to your code. It contained several lines that needed to be fixed, the overall style and layout could be improved, and the documentation as well. I've been picky as this code for now goes into crappy, I'll surely be less strict for code going directly to crappy.collection once it's implemented.

Can you please double-check that the code still works as expected on one of your cameras ? Once this is confirmed, or the necessary fixes are brought, I can merge this PR.

Thanks @WeisLeDocto , I will look at it tomrrow

@WeisLeDocto
Copy link
Member

Thanks @WeisLeDocto , I will look at it tomrrow

@jeffwitz could you check if the code works as expected ? So that I can merge this PR.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gphoto2 basic implementation
2 participants