-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CameraGphoto2 to existing crappy available cameras #118
base: develop
Are you sure you want to change the base?
Conversation
To make your new Camera object appear in the documentation, you'll need to add it at two separate places in the documentation source files:
You can check locally that the documentation builds as expected, by installing |
I add everything, Do I need to redo, or do you see the changes ? |
The documentation couldn't build after your modifications, see the build log for details. |
The new spelling is the one used by the gPhoto2 library
Might be useful for future debugging
Would lead to crash if called before the camera is instantiated. No effect here since settings are not implemented, but this might change in the future
I made some substantial changes to your code. It contained several lines that needed to be fixed, the overall style and layout could be improved, and the documentation as well. I've been picky as this code for now goes into Can you please double-check that the code still works as expected on one of your cameras ? Once this is confirmed, or the necessary fixes are brought, I can merge this PR. |
Thanks @WeisLeDocto , I will look at it tomrrow |
@jeffwitz could you check if the code works as expected ? So that I can merge this PR. Thanks |
This is a pull request for the implementation of the DSLR cameras.
It uses the gphoto2 library in order to capture images