Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include an internal check for empty prokka fasta files #6

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

papanikos
Copy link
Contributor

Hello @deyvidamgarten ,

I run into an issue where, for some of the contigs I was analyzing with marvel, prokka was producing empty protein fastas. These caused later hmmer searches to fail and the whole marvel workflow was failing.

This pull request addresses this issue.

  • I included a small cleanup step of the intermediate prokka output so that the analysis keeps going. If everything is removed exit and warn the user.
  • I included an environment.yml that freezes some dependencies to versions that worked for me. Since this was published, packages have been updated and the latest versions of biopython and scikit-learn throw errors. This is meant to be used with conda.
  • A brief description of how to use the environment.yml with conda is also included in the README.

I tested it with some of my broken files and it works as expected, at least the erroneous bins are skipped.

@deyvidamgarten
Copy link
Contributor

Hello Nikos,

Thank you for addressing this issue. I really appreciate it.

Cheers

@deyvidamgarten deyvidamgarten merged commit b096b04 into LaboratorioBioinformatica:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants