Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voasis #1165

Merged
merged 14 commits into from
Jun 19, 2024
Merged

voasis #1165

merged 14 commits into from
Jun 19, 2024

Conversation

aquestry
Copy link
Contributor

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Remove directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

github-actions[bot]
github-actions bot previously requested changes Jun 17, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove / at the end of url (social.web)
  • Please remove / at the end of url (social.web_support)

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

maaaathis
maaaathis suggested changes Jun 17, 2024
View reviewed changes
minecraft_servers/voasis/background.png Outdated Show resolved Hide resolved
minecraft_servers/voasis/background@2x.png Outdated Show resolved Hide resolved
minecraft_servers/voasis/manifest.json Show resolved Hide resolved
minecraft_servers/voasis/manifest.json Outdated Show resolved Hide resolved
@aquestry
Copy link
Contributor Author

i think i now have everything needed

@DoJapHD DoJapHD merged commit 313b8e3 into LabyMod:master Jun 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DoJapHD DoJapHD DoJapHD approved these changes

@maaaathis maaaathis Awaiting requested review from maaaathis

@github-actions github-actions[bot] Awaiting requested review from github-actions[bot]

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aquestry @maaaathis @DoJapHD