Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blotcraft #215

Merged
merged 19 commits into from
Feb 11, 2022
Merged

Blotcraft #215

merged 19 commits into from
Feb 11, 2022

Conversation

Blotcraft
Copy link
Contributor

@Blotcraft Blotcraft commented Feb 6, 2022

Type of change

  • Add new directory for a server
  • Update directory of a server
  • Documentation Update

Checklist

  • I have read the README doc
  • I have compressed the images appropriately (e.g. on https://tinypng.com)
  • I have created the manifest.json with the required values

Further comments

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/blotcraft/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • JSON is invalid! Workflow is not able to check minecraft_servers/blotcraft/manifest.json

Please fix the issues by pushing one commit to the pull request to prevent too many automatic reviews.

Copy link
Member

@JakobBruening JakobBruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, it would be great to improve spacing in your manifest.json. Use our example manifest.json as an example:
https://github.com/LabyMod/server-media/blob/master/docs/Manifest.md

minecraft_servers/blotcraft/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/blotcraft/manifest.json Outdated Show resolved Hide resolved
minecraft_servers/blotcraft/manifest.json Outdated Show resolved Hide resolved
@JakobBruening
Copy link
Member

Again: It would be great to improve spacing in your manifest.json. - Formatting is still not good :)

Use our example manifest.json as an example:
https://github.com/LabyMod/server-media/blob/master/docs/Manifest.md

I don't understand what is happening, since when I open it in my .JSON editor (Atom) it comes out perfectly and when I pass it here it comes out with more spaces. I removed the gamemodes but everything else is as you requested.
Sorry for the mistakes.
Copy link
Member

@JakobBruening JakobBruening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yesss, that looks better! Thank you very much! :)

@JakobBruening JakobBruening merged commit 9aff1e1 into LabyMod:master Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants