Fix for 'Cannot invoke ... because "classPath" is null.' #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
always complete the background task, even if an error occurs
fix exception when hotswapping with IntelliJ 2023.1 using the new UI, version 2.5, closes LabyStudio#9
Compiler output can contain non-class files like files generated by annotation processing. These cannot be "hotswapped" and don't have a classname, so have to be filtered out.
|
We sometimes had the same error in some classes and I haven't had time to debug it yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
we are using annotation processing to generate mapping files for internationalisation at compile time. These are properies-files, which causes this plugin to error out, since the compile task returns the properties files along with the "normal" class files as compiler output. However, these properties files do not have a classname and thus
BuiltInJavaCompilerthrows an exception, when trying to create aClassFileobject. This pull request fixes this issue, so thatClassFile-objects are only created for actual classes. I did some debugging and can also say, that filtering out these files matches the behaviour, when checking withHotSwapManager.scanForModifiedClasses, so although I am not an expert in the IntelliJ-Platform and Plugin-API I think this is the correct fix for this issue.With this fix in place, the issue did not occur and the classes were being hotswapped, as expected.
Thanks for providing this plugin and all the best
Jonas