LibWeb/HTML: Unregister ESO during finalize phase

It is generally safer for GC cells to do cleanup work during the
finalize phase.

Author: shannonbooth

Libraries/LibWeb/HTML/Scripting/Environments.cpp

@@ -44,9 +44,10 @@ EnvironmentSettingsObject::EnvironmentSettingsObject(NonnullOwnPtr<JS::Execution
     responsible_event_loop().register_environment_settings_object({}, *this);
 }
 
-EnvironmentSettingsObject::~EnvironmentSettingsObject()
+void EnvironmentSettingsObject::finalize()
 {
     responsible_event_loop().unregister_environment_settings_object({}, *this);
+    Base::finalize();
 }
 
 void EnvironmentSettingsObject::initialize(JS::Realm& realm)

Libraries/LibWeb/HTML/Scripting/Environments.h

@@ -76,7 +76,7 @@ struct EnvironmentSettingsObject : public Environment {
     GC_CELL(EnvironmentSettingsObject, Environment);
 
 public:
-    virtual ~EnvironmentSettingsObject() override;
+    virtual void finalize() override;
     virtual void initialize(JS::Realm&) override;
 
     // https://html.spec.whatwg.org/multipage/webappapis.html#concept-environment-target-browsing-context