LibWeb/CSS: Use serialize_a_number() for Angle serialization

Gets us 12 known passes!

Author: AtkinsSJ

Libraries/LibWeb/CSS/Angle.cpp

@@ -7,6 +7,7 @@
 #include <AK/Math.h>
 #include <LibWeb/CSS/Angle.h>
 #include <LibWeb/CSS/Percentage.h>
+#include <LibWeb/CSS/Serialize.h>
 #include <LibWeb/CSS/StyleValues/CalculatedStyleValue.h>
 
 namespace Web::CSS {
@@ -29,9 +30,20 @@ Angle Angle::percentage_of(Percentage const& percentage) const
 
 String Angle::to_string(SerializationMode serialization_mode) const
 {
-    if (serialization_mode == SerializationMode::ResolvedValue)
-        return MUST(String::formatted("{}deg", to_degrees()));
-    return MUST(String::formatted("{}{}", raw_value(), unit_name()));
+    // https://drafts.csswg.org/cssom/#serialize-a-css-value
+    // -> <angle>
+    // The <number> component serialized as per <number> followed by the unit in canonical form as defined in its
+    // respective specification.
+    if (serialization_mode == SerializationMode::ResolvedValue) {
+        StringBuilder builder;
+        serialize_a_number(builder, to_degrees());
+        builder.append("deg"sv);
+        return builder.to_string_without_validation();
+    }
+    StringBuilder builder;
+    serialize_a_number(builder, raw_value());
+    builder.append(unit_name());
+    return builder.to_string_without_validation();
 }
 
 double Angle::to_degrees() const

Tests/LibWeb/Text/expected/wpt-import/css/css-values/acos-asin-atan-atan2-serialize.txt

@@ -2,8 +2,7 @@ Harness status: OK
 
 Found 62 tests
 
-50 Pass
-12 Fail
+62 Pass
 Pass	'rotate(acos(1))' as a specified value should serialize as 'rotate(calc(0deg))'.
 Pass	'rotate(calc(acos(1)))' as a specified value should serialize as 'rotate(calc(0deg))'.
 Pass	'rotate(acos(-1))' as a specified value should serialize as 'rotate(calc(180deg))'.
@@ -14,10 +13,10 @@ Pass	'rotate(acos(1.5))' as a specified value should serialize as 'rotate(calc(N
 Pass	'rotate(calc(acos(1.5)))' as a specified value should serialize as 'rotate(calc(NaN * 1deg))'.
 Pass	'rotate(acos(2))' as a specified value should serialize as 'rotate(calc(NaN * 1deg))'.
 Pass	'rotate(calc(acos(2)))' as a specified value should serialize as 'rotate(calc(NaN * 1deg))'.
-Fail	'rotate(acos(0.5))' as a specified value should serialize as 'rotate(calc(60deg))'.
-Fail	'rotate(calc(acos(0.5)))' as a specified value should serialize as 'rotate(calc(60deg))'.
-Fail	'rotate(acos(1 - 0.5))' as a specified value should serialize as 'rotate(calc(60deg))'.
-Fail	'rotate(calc(acos(1 - 0.5)))' as a specified value should serialize as 'rotate(calc(60deg))'.
+Pass	'rotate(acos(0.5))' as a specified value should serialize as 'rotate(calc(60deg))'.
+Pass	'rotate(calc(acos(0.5)))' as a specified value should serialize as 'rotate(calc(60deg))'.
+Pass	'rotate(acos(1 - 0.5))' as a specified value should serialize as 'rotate(calc(60deg))'.
+Pass	'rotate(calc(acos(1 - 0.5)))' as a specified value should serialize as 'rotate(calc(60deg))'.
 Pass	'rotate(acos(0))' as a specified value should serialize as 'rotate(calc(90deg))'.
 Pass	'rotate(calc(acos(0)))' as a specified value should serialize as 'rotate(calc(90deg))'.
 Pass	'rotate(asin(1))' as a specified value should serialize as 'rotate(calc(90deg))'.
@@ -30,10 +29,10 @@ Pass	'rotate(asin(1.5))' as a specified value should serialize as 'rotate(calc(N
 Pass	'rotate(calc(asin(1.5)))' as a specified value should serialize as 'rotate(calc(NaN * 1deg))'.
 Pass	'rotate(asin(2))' as a specified value should serialize as 'rotate(calc(NaN * 1deg))'.
 Pass	'rotate(calc(asin(2)))' as a specified value should serialize as 'rotate(calc(NaN * 1deg))'.
-Fail	'rotate(asin(0.5))' as a specified value should serialize as 'rotate(calc(30deg))'.
-Fail	'rotate(calc(asin(0.5)))' as a specified value should serialize as 'rotate(calc(30deg))'.
-Fail	'rotate(asin(1 - 0.5))' as a specified value should serialize as 'rotate(calc(30deg))'.
-Fail	'rotate(calc(asin(1 - 0.5)))' as a specified value should serialize as 'rotate(calc(30deg))'.
+Pass	'rotate(asin(0.5))' as a specified value should serialize as 'rotate(calc(30deg))'.
+Pass	'rotate(calc(asin(0.5)))' as a specified value should serialize as 'rotate(calc(30deg))'.
+Pass	'rotate(asin(1 - 0.5))' as a specified value should serialize as 'rotate(calc(30deg))'.
+Pass	'rotate(calc(asin(1 - 0.5)))' as a specified value should serialize as 'rotate(calc(30deg))'.
 Pass	'rotate(asin(0))' as a specified value should serialize as 'rotate(calc(0deg))'.
 Pass	'rotate(calc(asin(0)))' as a specified value should serialize as 'rotate(calc(0deg))'.
 Pass	'rotate(acos(pi - pi))' as a specified value should serialize as 'rotate(calc(90deg))'.
@@ -42,14 +41,14 @@ Pass	'rotate(asin(pi - pi + 1))' as a specified value should serialize as 'rotat
 Pass	'rotate(calc(asin(pi - pi + 1)))' as a specified value should serialize as 'rotate(calc(90deg))'.
 Pass	'rotate(atan(1))' as a specified value should serialize as 'rotate(calc(45deg))'.
 Pass	'rotate(calc(atan(1)))' as a specified value should serialize as 'rotate(calc(45deg))'.
-Fail	'rotate(atan(0.577350269))' as a specified value should serialize as 'rotate(calc(30deg))'.
-Fail	'rotate(calc(atan(0.577350269)))' as a specified value should serialize as 'rotate(calc(30deg))'.
+Pass	'rotate(atan(0.577350269))' as a specified value should serialize as 'rotate(calc(30deg))'.
+Pass	'rotate(calc(atan(0.577350269)))' as a specified value should serialize as 'rotate(calc(30deg))'.
 Pass	'rotate(atan(0))' as a specified value should serialize as 'rotate(calc(0deg))'.
 Pass	'rotate(calc(atan(0)))' as a specified value should serialize as 'rotate(calc(0deg))'.
 Pass	'rotate(atan(infinity))' as a specified value should serialize as 'rotate(calc(90deg))'.
 Pass	'rotate(calc(atan(infinity)))' as a specified value should serialize as 'rotate(calc(90deg))'.
-Fail	'rotate(atan2(37.320508075, 10))' as a specified value should serialize as 'rotate(calc(75deg))'.
-Fail	'rotate(calc(atan2(37.320508075, 10)))' as a specified value should serialize as 'rotate(calc(75deg))'.
+Pass	'rotate(atan2(37.320508075, 10))' as a specified value should serialize as 'rotate(calc(75deg))'.
+Pass	'rotate(calc(atan2(37.320508075, 10)))' as a specified value should serialize as 'rotate(calc(75deg))'.
 Pass	'rotate(atan2(1s, 1000ms))' as a specified value should serialize as 'rotate(calc(45deg))'.
 Pass	'rotate(calc(atan2(1s, 1000ms)))' as a specified value should serialize as 'rotate(calc(45deg))'.
 Pass	'rotate(atan2(infinity, infinity))' as a specified value should serialize as 'rotate(calc(45deg))'.