UI/AppKit: Disable popup blocking on startup if --allow-popups is set

Author: tcl3

Ladybird/AppKit/Application/ApplicationDelegate.mm

@@ -188,6 +188,7 @@ - (nonnull TabController*)createNewTab:(Web::HTML::ActivateTab)activate_tab
     }
 
     [self.managed_tabs addObject:controller];
+    [controller onCreateNewTab];
     return controller;
 }
 

Ladybird/AppKit/UI/TabController.h

@@ -35,11 +35,14 @@ struct TabSettings {
 
 - (void)onTitleChange:(ByteString const&)title;
 
+- (void)onCreateNewTab;
+
 - (void)navigateBack:(id)sender;
 - (void)navigateForward:(id)sender;
 - (void)reload:(id)sender;
 - (void)clearHistory;
 
+- (void)setPopupBlocking:(BOOL)block_popups;
 - (void)debugRequest:(ByteString const&)request argument:(ByteString const&)argument;
 
 - (void)focusLocationToolbarItem;

Ladybird/AppKit/UI/TabController.mm

@@ -139,6 +139,11 @@ - (void)onTitleChange:(ByteString const&)title
     m_title = title;
 }
 
+- (void)onCreateNewTab
+{
+    [self setPopupBlocking:m_settings.block_popups];
+}
+
 - (void)zoomIn:(id)sender
 {
     [[[self tab] web_view] zoomIn];
@@ -348,7 +353,12 @@ - (void)toggleScripting:(id)sender
 - (void)togglePopupBlocking:(id)sender
 {
     m_settings.block_popups = !m_settings.block_popups;
-    [self debugRequest:"block-pop-ups" argument:m_settings.block_popups ? "on" : "off"];
+    [self setPopupBlocking:m_settings.block_popups];
+}
+
+- (void)setPopupBlocking:(BOOL)block_popups
+{
+    [self debugRequest:"block-pop-ups" argument:block_popups ? "on" : "off"];
 }
 
 - (void)toggleSameOriginPolicy:(id)sender