LibWeb/CSS: Use ErrorReporter for value-parsing errors

Also remove some redundant reporting for `<urange>` parsing errors.

Author: AtkinsSJ

Libraries/LibWeb/CSS/Parser/Parser.cpp

@@ -20,6 +20,7 @@
 #include <LibWeb/CSS/CSSStyleSheet.h>
 #include <LibWeb/CSS/FontFace.h>
 #include <LibWeb/CSS/MediaList.h>
+#include <LibWeb/CSS/Parser/ErrorReporter.h>
 #include <LibWeb/CSS/Parser/Parser.h>
 #include <LibWeb/CSS/PropertyName.h>
 #include <LibWeb/CSS/Sizing.h>
@@ -1750,7 +1751,11 @@ LengthOrCalculated Parser::parse_as_sizes_attribute(DOM::Element const& element,
         remove_all_consecutive_whitespace_tokens_from_the_end_of(unparsed_size);
         if (unparsed_size.is_empty()) {
             log_parse_error();
-            dbgln_if(CSS_PARSER_DEBUG, "-> Failed in step 3.1; all whitespace");
+            ErrorReporter::the().report(InvalidValueError {
+                .value_type = "sizes attribute"_fly_string,
+                .value_string = m_token_stream.dump_string(),
+                .description = "Failed in step 3.1; all whitespace"_string,
+            });
             continue;
         }
 
@@ -1764,7 +1769,11 @@ LengthOrCalculated Parser::parse_as_sizes_attribute(DOM::Element const& element,
             unparsed_size.take_last();
         } else {
             log_parse_error();
-            dbgln_if(CSS_PARSER_DEBUG, "-> Failed in step 3.2; couldn't parse {} as a <source-size-value>", unparsed_size.last().to_debug_string());
+            ErrorReporter::the().report(InvalidValueError {
+                .value_type = "sizes attribute"_fly_string,
+                .value_string = m_token_stream.dump_string(),
+                .description = "Failed in step 3.2; couldn't parse {} as a <source-size-value>"_string,
+            });
             continue;
         }
 
@@ -1789,7 +1798,11 @@ LengthOrCalculated Parser::parse_as_sizes_attribute(DOM::Element const& element,
             // 1. If this was not the last item in unparsed sizes list, that is a parse error.
             if (i != unparsed_sizes_list.size() - 1) {
                 log_parse_error();
-                dbgln_if(CSS_PARSER_DEBUG, "-> Failed in step 3.4.1; is unparsed size #{}, count {}", i, unparsed_sizes_list.size());
+                ErrorReporter::the().report(InvalidValueError {
+                    .value_type = "sizes attribute"_fly_string,
+                    .value_string = m_token_stream.dump_string(),
+                    .description = MUST(String::formatted("Failed in step 3.4.1; is unparsed size #{}, count {}", i, unparsed_sizes_list.size())),
+                });
             }
 
             // 2. If size is not auto, then return size. Otherwise, continue.

Libraries/LibWeb/CSS/Parser/PropertyParsing.cpp

@@ -17,6 +17,7 @@
 #include <AK/QuickSort.h>
 #include <LibWeb/CSS/CSSStyleValue.h>
 #include <LibWeb/CSS/CharacterTypes.h>
+#include <LibWeb/CSS/Parser/ErrorReporter.h>
 #include <LibWeb/CSS/Parser/Parser.h>
 #include <LibWeb/CSS/StyleValues/AngleStyleValue.h>
 #include <LibWeb/CSS/StyleValues/BackgroundRepeatStyleValue.h>
@@ -2412,7 +2413,11 @@ RefPtr<CSSStyleValue const> Parser::parse_display_value(TokenStream<ComponentVal
             }
 
             // Not a display value, abort.
-            dbgln_if(CSS_PARSER_DEBUG, "Unrecognized display value: `{}`", tokens.next_token().to_string());
+            ErrorReporter::the().report(InvalidValueError {
+                .value_type = "<display>"_fly_string,
+                .value_string = tokens.next_token().to_string(),
+                .description = "Unrecognized value"_string,
+            });
             return {};
         }
 
@@ -3924,12 +3929,20 @@ RefPtr<CSSStyleValue const> Parser::parse_transform_value(TokenStream<ComponentV
         auto arguments = parse_a_comma_separated_list_of_component_values(function_tokens);
 
         if (arguments.size() > function_metadata.parameters.size()) {
-            dbgln_if(CSS_PARSER_DEBUG, "Too many arguments to {}. max: {}", part.function().name, function_metadata.parameters.size());
+            ErrorReporter::the().report(InvalidValueError {
+                .value_type = "<transform-function>"_fly_string,
+                .value_string = part.function().original_source_text(),
+                .description = MUST(String::formatted("Too many arguments to {}. max: {}", part.function().name, function_metadata.parameters.size())),
+            });
             return nullptr;
         }
 
         if (arguments.size() < function_metadata.parameters.size() && function_metadata.parameters[arguments.size()].required) {
-            dbgln_if(CSS_PARSER_DEBUG, "Required parameter at position {} is missing", arguments.size());
+            ErrorReporter::the().report(InvalidValueError {
+                .value_type = "<transform-function>"_fly_string,
+                .value_string = part.function().original_source_text(),
+                .description = MUST(String::formatted("Required parameter at position {} is missing", arguments.size())),
+            });
             return nullptr;
         }
 

Libraries/LibWeb/CSS/Parser/SyntaxParsing.cpp

@@ -6,6 +6,7 @@
 
 #include <AK/GenericShorthands.h>
 #include <LibWeb/CSS/Parser/ArbitrarySubstitutionFunctions.h>
+#include <LibWeb/CSS/Parser/ErrorReporter.h>
 #include <LibWeb/CSS/Parser/Parser.h>
 #include <LibWeb/CSS/Parser/Syntax.h>
 #include <LibWeb/CSS/Parser/SyntaxParsing.h>
@@ -251,7 +252,11 @@ RefPtr<CSSStyleValue const> Parser::parse_according_to_syntax_node(TokenStream<C
             return nullptr;
         }
 
-        dbgln_if(CSS_PARSER_DEBUG, "Couldn't parse `<{}>` because we don't know what it is.", type_name);
+        ErrorReporter::the().report(InvalidValueError {
+            .value_type = MUST(String::formatted("<{}>", type_name)),
+            .value_string = tokens.dump_string(),
+            .description = "Unknown type in <syntax>."_string,
+        });
         return nullptr;
     }
     case SyntaxNode::NodeType::Multiplier: {