LibWeb: Apply HTMLFontElement's face attribute's presentational hint

Lubrsi · kalenikaliaksandr · commit ee6dbcc96efb · 2025-04-01T03:50:30.000+02:00
Fixes font selection on https://stagsnet.net/
diff --git a/Libraries/LibWeb/HTML/HTMLFontElement.cpp b/Libraries/LibWeb/HTML/HTMLFontElement.cpp
@@ -125,19 +125,23 @@ bool HTMLFontElement::is_presentational_hint(FlyString const& name) const
 void HTMLFontElement::apply_presentational_hints(GC::Ref<CSS::CascadedProperties> cascaded_properties) const
 {
     for_each_attribute([&](auto& name, auto& value) {
-        if (name.equals_ignoring_ascii_case("color"sv)) {
+        if (name == AttributeNames::color) {
             // https://html.spec.whatwg.org/multipage/rendering.html#phrasing-content-3:rules-for-parsing-a-legacy-colour-value
             auto color = parse_legacy_color_value(value);
             if (color.has_value())
                 cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::Color, CSS::CSSColorValue::create_from_color(color.value(), CSS::ColorSyntax::Legacy));
-        } else if (name.equals_ignoring_ascii_case("size"sv)) {
+        } else if (name == AttributeNames::size) {
             // When a font element has a size attribute, the user agent is expected to use the following steps, known as the rules for parsing a legacy font size, to treat the attribute as a presentational hint setting the element's 'font-size' property:
             auto font_size_or_empty = parse_legacy_font_size(value);
             if (font_size_or_empty.has_value()) {
                 auto font_size = string_from_keyword(font_size_or_empty.release_value());
                 if (auto parsed_value = parse_css_value(CSS::Parser::ParsingParams { document() }, font_size, CSS::PropertyID::FontSize))
                     cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::FontSize, parsed_value.release_nonnull());
             }
+        } else if (name == AttributeNames::face) {
+            // When a font element has a face attribute, the user agent is expected to treat the attribute as a presentational hint setting the element's 'font-family' property to the attribute's value.
+            if (auto parsed_value = parse_css_value(CSS::Parser::ParsingParams { document() }, value, CSS::PropertyID::FontFamily))
+                cascaded_properties->set_property_from_presentational_hint(CSS::PropertyID::FontFamily, parsed_value.release_nonnull());
         }
     });
 }
diff --git a/Tests/LibWeb/Ref/expected/HTML/HTMLFontElement-face-attribute-ref.html b/Tests/LibWeb/Ref/expected/HTML/HTMLFontElement-face-attribute-ref.html
@@ -0,0 +1,12 @@
+<!DOCTYPE html>
+<head>
+     <link rel="match" href="../../expected/HTML/HTMLFontElement-face-attribute-ref.html" />
+<style>
+    span {
+        font-family: 'Arial', sans-serif;
+    }
+</style>
+</head>
+<body>
+     <span>Well hello friends!</span>
+</body>
diff --git a/Tests/LibWeb/Ref/input/HTML/HTMLFontElement-face-attribute.html b/Tests/LibWeb/Ref/input/HTML/HTMLFontElement-face-attribute.html
@@ -0,0 +1,7 @@
+<!DOCTYPE html>
+<head>
+     <link rel="match" href="../../expected/HTML/HTMLFontElement-face-attribute-ref.html" />
+</head>
+<body>
+     <font face="'Arial', sans-serif"><span>Well hello friends!</span></font>
+</body>
diff --git a/Tests/LibWeb/Text/expected/Editing/execCommand-fontName.txt b/Tests/LibWeb/Text/expected/Editing/execCommand-fontName.txt
@@ -1,2 +1,2 @@
-foo<font face="monospace" style="font-family: monospace;">bar</font>
-<font face="sans-serif" style="font-family: sans-serif;">foo</font><font face="sans-serif" style="font-family: sans-serif;"><font style="">bar</font></font>
+foo<font face="monospace">bar</font>
+<font face="sans-serif">foobar</font>
