LibWeb: Preserve comments in XML documents

ADKaster · alimpfard · commit f9f854b4932d · 2025-07-19T14:56:20.000+02:00
diff --git a/Libraries/LibWeb/DOM/DocumentLoading.cpp b/Libraries/LibWeb/DOM/DocumentLoading.cpp
@@ -178,7 +178,7 @@ static WebIDL::ExceptionOr<GC::Ref<DOM::Document>> load_xml_document(HTML::Navig
             document->completely_finish_loading();
             return;
         }
-        XML::Parser parser(source.value(), { .resolve_external_resource = resolve_xml_resource });
+        XML::Parser parser(source.value(), { .preserve_cdata = true, .preserve_comments = true, .resolve_external_resource = resolve_xml_resource });
         XMLDocumentBuilder builder { document };
         auto result = parser.parse_with_listener(builder);
         if (result.is_error()) {

Original file line number	Diff line number	Diff line change
`@@ -178,7 +178,7 @@ static WebIDL::ExceptionOr<GC::Ref<DOM::Document>> load_xml_document(HTML::Navig`
`178`	`178`	`document->completely_finish_loading();`
`179`	`179`	`return;`
`180`	`180`	`}`
`181`		`- XML::Parser parser(source.value(), { .resolve_external_resource = resolve_xml_resource });`
	`181`	`+ XML::Parser parser(source.value(), { .preserve_cdata = true, .preserve_comments = true, .resolve_external_resource = resolve_xml_resource });`
`182`	`182`	`XMLDocumentBuilder builder { document };`
`183`	`183`	`auto result = parser.parse_with_listener(builder);`
`184`	`184`	`if (result.is_error()) {`