Common issues fixes & some style and translation updates #44
Conversation
| @@ -26,6 +26,7 @@ Simple CMS for Sylius. | |||
| new \Symfony\Cmf\Bundle\MenuBundle\CmfMenuBundle(), | |||
| new \Symfony\Cmf\Bundle\RoutingBundle\CmfRoutingBundle(), | |||
| new \Lakion\SyliusCmsBundle\LakionSyliusCmsBundle(), | |||
| new \Symfony\Cmf\Bundle\MediaBundle\CmfMediaBundle(), | |||
There was a problem hiding this comment.
Would be better to move it right above CmfMenuBundle, for consistency's sake, since everything else is apparently in alphabetical order. Of course if there's no inner conflict with the loading order of these bundles.
| link: "Link" | ||
| name: "Name" | ||
| title: "Title" | ||
| body: Body |
There was a problem hiding this comment.
Quoting the messages is a precaution since some words are restricted in yaml, etc. yes/no get transformed to boolean when not encapsulated in quotes.
Possibly there're more words like that, and it may cause unexpected visual issues further on.
| routes: Routes | ||
| static_contents: Static contents | ||
| string_blocks: String blocks | ||
| taxon_blocks: Taxon blocks |
There was a problem hiding this comment.
Missing new line at the end.
| 8. Initialize PHPCR repository | ||
|
|
||
| ```bash | ||
| $ bin/console doctrine:phpcr:repository:init |
| @@ -31,7 +31,7 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| ->add('image', FileType::class, [ | |||
| 'label' => 'lakion_sylius_cms.form.taxon_block.image', | |||
| ]) | |||
| ->add('taxon', TaxonChoiceType::class, [ | |||
| ->add('taxon', TaxonAutocompleteChoiceType::class, [ | |||
There was a problem hiding this comment.
Quite sure you'd also need to update the template to make it work as expected.
Just add {% form_theme form '@SyliusAdmin/Form/theme.html.twig' %} at the top of views\Admin\TaxonBlock\_form.html.twig
|
Merged in #48. Thanks for your work Mikołaj! 👍 |
#43