Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leniency for early/late note hits #62

Open
Lamby777 opened this issue May 18, 2024 · 4 comments
Open

Leniency for early/late note hits #62

Lamby777 opened this issue May 18, 2024 · 4 comments
Assignees
Labels
battles Battle engine issues enhancement New feature or request godot GDScript and engine-related stuff rust GDExtension Rust-related stuff

Comments

@Lamby777
Copy link
Owner

This is gonna be increasingly difficult to implement.

@Lamby777 Lamby777 added enhancement New feature or request rust GDExtension Rust-related stuff godot GDScript and engine-related stuff battles Battle engine issues labels May 18, 2024
@Lamby777 Lamby777 added this to the Core Functionality Complete milestone May 18, 2024
Lamby777 added a commit that referenced this issue May 18, 2024
Lamby777 added a commit that referenced this issue May 19, 2024
@Lamby777
Copy link
Owner Author

Idea: Player clicks should NOT delay a second check, but rather set another player_clicked variable to true, and then if a "note on" is received while that is true, the note counts as being clicked. However, a timeout is needed to still punish the player if they clicked TOO early. This timer should be cancelled if the click was successful.

@Lamby777
Copy link
Owner Author

Lamby777 commented May 19, 2024

A little sketch of what I mean, in case I forget later

image

@Lamby777 Lamby777 changed the title Leniency for "early" note hits Leniency for early/late note hits May 19, 2024
@Lamby777
Copy link
Owner Author

Closing as irrelevant. Manually implementing my own midi reader stuff using midly.

@Lamby777 Lamby777 reopened this May 22, 2024
@Lamby777 Lamby777 self-assigned this May 22, 2024
@Lamby777
Copy link
Owner Author

Relevant again; early clicks seem to be counted as wrong... Either that or just skill issue idk, but @IIIzP0III had the issue too when playing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
battles Battle engine issues enhancement New feature or request godot GDScript and engine-related stuff rust GDExtension Rust-related stuff
Projects
None yet
Development

No branches or pull requests

1 participant