Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client side OrganizationData Usage #29

Merged
merged 10 commits into from
Apr 29, 2022
Merged

Client side OrganizationData Usage #29

merged 10 commits into from
Apr 29, 2022

Conversation

Apfelwurm
Copy link
Member

@Apfelwurm Apfelwurm commented Apr 28, 2022 •
edited
Loading

Todo:

  • check strange migration warning (you can get it by deleting the database or migrate from main)
warn: Microsoft.EntityFrameworkCore.Migrations[30200]
      An operation of type 'InsertDataOperation' will be attempted while a rebuild of table 'OrganizationData' is pending. The database may not be in an expected state. Review the SQL generated by this migration to help diagnose any failures. Consider moving these operations to a subsequent migration.
  • fix code smells

@Apfelwurm Apfelwurm mentioned this pull request Apr 29, 2022
Closed
Apfelwurm added a commit that referenced this pull request Apr 29, 2022
@Apfelwurm
removed cultureinfo, will be implemented in #29
0804cf2
@Apfelwurm Apfelwurm mentioned this pull request Apr 29, 2022
Merged
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@MD-V MD-V marked this pull request as ready for review April 29, 2022 15:03
@MD-V MD-V merged commit a61ff57 into main Apr 29, 2022
@MD-V MD-V deleted the feature/OrganizationDataSampleUsage branch April 29, 2022 15:04
@Apfelwurm Apfelwurm mentioned this pull request Apr 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Apfelwurm @MD-V