Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs typo fixes #97

Merged
merged 7 commits into from
Jul 9, 2023
Merged

Docs typo fixes #97

merged 7 commits into from
Jul 9, 2023

Conversation

tatzati
Copy link
Contributor

@tatzati tatzati commented Jul 9, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Going throw the documentation and decided to contribute to the docs.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Documentation (typos, code examples or any documentation update)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project (scripts/lint.sh has no errors)
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@Lancetnik
Copy link
Owner

@tatzati thx a lot for your help! Do you have any planes to contribute again later? This kind of contribution is the best!

@Lancetnik Lancetnik merged commit fa78031 into Lancetnik:main Jul 9, 2023
@tatzati
Copy link
Contributor Author

tatzati commented Jul 10, 2023

@Lancetnik hey there! I am looking for a nice project to contribute, and I found this one through r/opensource. I was looking at the docs to figure out what this was about, and thought I would land a help while doing so. I have about seven years of experience with python mostly on django and flask, and regarding messaging systems I have only used rabbitmq to broker tasks to celery and a little bit of kafka in some cases, but nothing much outside of that. I would like to learn more about this project and see if I can contribute more to the codebase. If possible, I would very much appreciate someone to mentor me on the current state of the project and prepare me to be able to contribute as much as I can. Cheers!

@Lancetnik
Copy link
Owner

@tatzati I am happy to see a developer with your experience ready to go deeper into the project. Don't worry about messaging - you will quickly fall in.

The core project architecture you can find here and specific broker implementation is described as well. So, you can check the code and the doc to be familiar with "how it works".

The main direction right now: build a sync project version (to be compatible with django/flask) and ZeroMQ support (brokerless pub/sub should be an extremely helpful tool for many python backend developers), also I am working on better AsyncAPI integration (you can check the spec and integrate more fields to Propan application, but it's not your level task, I suppose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants