Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lua] Correct 'Smite of rage' shadow behavior and fTP #5229

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

CatsEyeXI
Copy link

I affirm:

  • I understand that if I do not agree to the following points by completing the checkboxes my PR will be ignored.
  • I understand I should leave resolving conversations to the LandSandBoat team so that reviewers won't miss what was said.
  • I have read and understood the Contributing Guide and the Code of Conduct.
  • I have tested my code and the things my code has changed since the last commit in the PR and will test after any later commits.

What does this pull request do?

Smite of Rage is currently consuming between 2-3 shadows. It is a single hit weaponskill.
This change removes the random removal of 2-3 shadows as well as updates the mobskill script to align with current LSB standard.
Tested as Lv75 SAM on Aura Weapons.

image

Steps to test these changes

Go to your favorite 'weapon' mob and spam !exec target:useMobAbility(513)

@Xaver-DaRed Xaver-DaRed changed the title 'Smite of rage' is not multi-hit [Lua] Correct 'Smite of rage' shadow behavior and fTP Mar 11, 2024
Copy link
Contributor

@TeoTwawki TeoTwawki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like smite began its life as copy paste of whirl.

@TeoTwawki TeoTwawki merged commit 876a468 into LandSandBoat:base Mar 11, 2024
12 checks passed
@CatsEyeXI CatsEyeXI deleted the smite_of_rage branch May 2, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants