Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure existing agents are not affected by deployer config changes #396

Merged
merged 7 commits into from
Sep 13, 2023

Conversation

nicoloboschi
Copy link
Member

Currently if the deployer gets upgraded/restarted, the new config is applied to ALL the agents/statefulsets.
That also means that every time the runtime version gets upgraded in the deployer, all the executors restart with the new runtime version.
There are problems with this policy:

  1. All the executors get restarted when a system upgrade is performed. This is very bad for the user experience/performance/stability.
  2. The executor should continue running that particular version of that the runtime. An agent change could break existing applications.

For the point 2, in the future it could implemented a flag "auto-update" to get the new runtime image whenever the application is upgraded - not the deployer.

Changes:

  • Save current configuration (only the relevant and public part) in the agent custom resource status and apply it if it's an update. If it's the statefulset creation (first deploy) it gets the current deployer configuration

Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

great catch (and fix)

@nicoloboschi nicoloboschi merged commit 7686bde into main Sep 13, 2023
8 checks passed
@nicoloboschi nicoloboschi deleted the ensure-agents-same-version branch September 13, 2023 15:23
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants