Provide a ThemeServiceProvider for themes #5148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY
BEFORE - What was wrong? What was happening before this PR?
Two things:
ThemeServiceProvider
andAddonServiceProvider
to CRUD #5147AFTER - What is happening after this PR?
Backpack provides a ThemeServiceProvider and that loads the views even if the theme isn't active.
HOW
How did you achieve that, in technical terms?
Is it a breaking change?
Yes. Sort of. I mean it's a breaking change only if you're using a particular version of a theme without having the latest version of CRUD too. Which is something only our team members would do. So no, non-breaking for anybody testing Backpack, other than our team members.