Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a ThemeServiceProvider for themes #5148

Merged
merged 2 commits into from
Jun 29, 2023
Merged

Conversation

tabacitu
Copy link
Member

WHY

BEFORE - What was wrong? What was happening before this PR?

Two things:

AFTER - What is happening after this PR?

Backpack provides a ThemeServiceProvider and that loads the views even if the theme isn't active.

HOW

How did you achieve that, in technical terms?

  • moved AutomaticServiceProvider from all themes to CRUD;
  • renamed it to ThemeServiceProvider;
  • turned it into a class (instead of a trait);
  • made all AddonServiceProviders in themes extend this new ThemeServiceProvider;

Is it a breaking change?

Yes. Sort of. I mean it's a breaking change only if you're using a particular version of a theme without having the latest version of CRUD too. Which is something only our team members would do. So no, non-breaking for anybody testing Backpack, other than our team members.

@tabacitu tabacitu self-assigned this Jun 29, 2023
@tabacitu
Copy link
Member Author

@tabacitu
Copy link
Member Author

@pxpm let me know if doing this sounds like a bad idea to you. No testing needed. Otherwise give me the green light, I'm gonna go ahead and merge. It's all tested and working great.

@tabacitu tabacitu assigned pxpm and tabacitu and unassigned tabacitu Jun 29, 2023
@tabacitu tabacitu merged commit 02a0a2f into v6 Jun 29, 2023
@tabacitu tabacitu deleted the add-theme-service-provider branch June 29, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants