Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to verify SSL on local #96

Merged
merged 5 commits into from
Sep 26, 2023
Merged

Avoid to verify SSL on local #96

merged 5 commits into from
Sep 26, 2023

Conversation

promatik
Copy link
Contributor

@promatik promatik commented Sep 6, 2023

Fixes #95.

This is a fix for local development where developers use self signed certificates (like the ones provided by Laragon or similar).

ERROR - cURL error 60: SSL certificate problem: self signed certificate (see https://curl.haxx.se/libcurl/c/libcurl-errors.html) for https://backpack.test/storage/basset/vendor/backpack/basset/tests/Helpers/basset-test.js.

This will make the HTTP to now verify the requests when dev_mode === true.

@promatik
Copy link
Contributor Author

After discussing this with Cristian, let's move to a proper configuration instead of depending on dev_mode.

It should be 'verify_ssl_certificate' => true.

@promatik promatik assigned promatik and unassigned tabacitu and pxpm Sep 12, 2023
@promatik promatik assigned pxpm and unassigned promatik Sep 13, 2023
Co-authored-by: Pedro Martins <pxpm88@gmail.com>
@promatik promatik requested a review from pxpm September 23, 2023 01:15
@promatik promatik assigned pxpm and unassigned promatik Sep 23, 2023
@Astriel
Copy link

Astriel commented Sep 23, 2023

Thank you guys for your work ! Will try this once it's merged to be able to validate it.

@tabacitu
Copy link
Member

@pxpm looks good to me. Anything holding us back from merging this?

src/BassetManager.php Outdated Show resolved Hide resolved
@pxpm pxpm merged commit a2f0afb into main Sep 26, 2023
5 checks passed
@pxpm
Copy link
Contributor

pxpm commented Sep 26, 2023

@pxpm looks good to me. Anything holding us back from merging this?

I had already reviewed this but didn't came back here after @promatik did the changes.

LGTM. Merged, Will tag a new version in a few moments after I test and merge other PR.

Thanks for the ping.

Cheers

@pxpm pxpm deleted the avoid-verify-local branch September 26, 2023 08:48
@Astriel
Copy link

Astriel commented Sep 28, 2023

Basset is working well now.
But the coreui-v4 is still broken even if basset is now fully working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cURL error 60: SSL certificate problem: self signed certificate
4 participants