Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composer-post-update-cmd.json #24

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

grrnikos
Copy link
Contributor

@grrnikos grrnikos commented Jan 10, 2024

Use @php instead of php as in the composer.json of Laravel.

Use `@php` instead of `php` as in the `composer.json` of the Laravel.
@andrey-helldar
Copy link
Member

This is not necessary since the use of the "@" symbol suppresses runtime errors. That is, if an error occurs during the execution of any command, it will not interrupt the execution of subsequent commands.

In our case this is not necessary. If we have an error, we need to get it here and now, since further calling the code will not make any sense without the successful result of the previous command.

@andrey-helldar
Copy link
Member

Although, in the final application, it may indeed not be important to execute these commands, as a result of which errors can be suppressed.

Copy link
Member

@andrey-helldar andrey-helldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@andrey-helldar andrey-helldar merged commit b01bb3d into Laravel-Lang:main Jan 10, 2024
2 of 3 checks passed
@grrnikos
Copy link
Contributor Author

grrnikos commented Jan 10, 2024

Thanks for clarifying this. My thought was to "sync" this snippet with the official composer.json that is being referenced. And if for some reason we'd need to output errors during development, we could just delete the @.

@grrnikos grrnikos deleted the patch-1 branch January 10, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants