Skip to content

Conversation

driesvints
Copy link
Member

This pull request includes the changes for upgrading to Laravel 5.6. Feel free to commit any additional changes to the shift-6274 branch.

Before merging, you should:

  • Checkout the shift-6274 branch
  • Review all pull request comments for additional changes
  • Update your dependencies for Laravel 5.6
  • Run composer update (if the pre-scripts fail, add --no-scripts)
  • Thoroughly test your application

If you need help with your upgrade, check out the Shift Human Services or join the Shifty Coders Slack room to get answers to all your Laravel questions.

@driesvints
Copy link
Member Author

driesvints commented Feb 11, 2018

⚠ In Laravel 5.6, the e helper will double encode special characters by default. If you would like to maintain the previous behavior of preventing double encoding, you may pass false as the second argument to the e helper

Shift found potential uses of the e helper in:

  • resources/views/forum/threads/show.blade.php

@driesvints
Copy link
Member Author

❌ Shift could not upgrade tests/CreatesApplication.php. You will need to compare yours against the 5.6 version and merge any new changes.

@driesvints
Copy link
Member Author

driesvints commented Feb 11, 2018

⚠ Shift could not upgrade the following project files since they differed from the default Laravel version. You should compare these project files against the default Laravel 5.6 versions and merge any changes:

  • .env.example

@driesvints
Copy link
Member Author

driesvints commented Feb 11, 2018

❌ Shift could not upgrade the following configuration files since they differed from the default Laravel version. You will need to compare these configuration files against the Laravel 5.6 configuration files and merge any changes:

  • config/app.php
  • config/mail.php
  • config/services.php

@driesvints
Copy link
Member Author

ℹ Laravel 5.6 introduced a logging configuration file. You should ensure the log and log_level settings previously in the config/app.php are now set in config/logging.php.

@driesvints
Copy link
Member Author

❌ Laravel 5.6 requires PHP 7.1.3. You have a modified dependency for PHP in your composer.json. Ensure it meets the new version requirement of >=7.1.3.

@driesvints
Copy link
Member Author

❌ Laravel 5.6 has a dependency for fideloper/proxy of ~4.0. You have a modified dependency for fideloper/proxy in your composer.json. Ensure it meets the new version requirement of ~4.0.

@driesvints
Copy link
Member Author

ℹ All of the underlying Symfony components used by Laravel have been upgraded to Symfony 4.0. If you are directly interacting with Symfony components, you should review the Symfony change log and update your application accordingly.

@driesvints
Copy link
Member Author

ℹ The previously deprecated optimize Artisan command has been removed. With recent improvements to PHP itself including the OPcache, the optimize command no longer provides any relevant performance benefit.

@driesvints
Copy link
Member Author

ℹ In Laravel 5.6, Blade will double encode special characters by default. If you would like to maintain the previous behavior of preventing double encoding, you may add Blade::withoutDoubleEncoding() to your AppServiceProvider boot method.

@driesvints
Copy link
Member Author

ℹ Laravel 5.6 uses Bootstrap 4 by default. Shift did not update your front-end resources or dependencies as this could impact your UI. If you are using Bootstrap and wish to continue using Bootstrap 3, you should add Paginator::useBootstrapThree() to your AppServiceProvider boot method.

@driesvints
Copy link
Member Author

ℹ If you have manually upgraded your app from previous versions of Laravel, you should run the Laravel Linter to ensure your app is fully upgraded to the latest version of Laravel.

@driesvints
Copy link
Member Author

driesvints commented Feb 11, 2018

❌ PHP syntax errors were detected after running your Shift. Often these are simply PHP version differences between Shift and your project. Occasionally they are misplaced lines. You should check the PHP syntax by running php -l on the following files:

  • app/Models/Thread.php
  • app/Providers/AppServiceProvider.php

@driesvints driesvints merged commit bd9113f into master Feb 18, 2018
@driesvints driesvints deleted the shift-6274 branch February 18, 2018 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants