Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Each element in an element is repeated 4 times #64

Closed
cgplayer2000 opened this issue Feb 17, 2023 · 7 comments
Closed

[BUG] Each element in an element is repeated 4 times #64

cgplayer2000 opened this issue Feb 17, 2023 · 7 comments
Labels
bug Something isn't working
Milestone

Comments

@cgplayer2000
Copy link

image

image

I click on each of the categories. Whatever drops down is repeated 4 times, which gets pretty massive on the Conditions category. It happens with PCs or NPCs. I've tested it with my normal module load, and with only Token Action HUD Core and Token Action HUD 5e installed. The problem persists. I thought that this might have been directly related to https://github.com/Larkinabout/fvtt-token-action-hud-core/issues/66 but the difference is that I get multiples of everything in the HUD, not just the spells.

Versions:

  • Token Action HUD Core: 1.2.1
  • Token Action HUD System: token-action-hud-dnd5e 1.2.1
  • System: 5e v2.1.4
  • Foundry VTT: 10.291
  • Browser: Google Chrome Version 110.0.5481.104

I attempted to clear up the token with the macro from #66 but no joy. I uninstalled both modules and re-installed them. No change. But, as far as I can tell, it has only happened on actors that I had placed an item modified with Items with Spells 5e.

@cgplayer2000 cgplayer2000 added the bug Something isn't working label Feb 17, 2023
@Larkinabout
Copy link
Owner

I'm still investigating, but if you open up the dialog for the subcategory and click Accept, it should clear out the duplicates. You might not have seen any change after disabling modules, as once the duplicate actions are on the HUD, they will stay there unless manually removed.

@cgplayer2000
Copy link
Author

cgplayer2000 commented Feb 18, 2023

I'm still investigating, but if you open up the dialog for the subcategory and click Accept, it should clear out the duplicates. You might not have seen any change after disabling modules, as once the duplicate actions are on the HUD, they will stay there unless manually removed.

That worked perfectly. Thanks. I'm still curious what is going on with the interaction with 'Items with Spells 5e'.

That said, when I use a token's capabilities, such as Hunter's Mark, I see four copies of it in the HUD. Now that I know how to remove them, it's not a big deal, However, it does look like a somewhat persistent issue.

@Larkinabout
Copy link
Owner

I think I've discovered the cause: it's any process that adds multiple items in one go, or at least triggers multiple actor updates. Each one causes the HUD update to be triggered and as they're running almost concurrently, they're all adding the same actions to the HUD at once. I'll need to add some sort of check that waits for the very last iteration to finish before triggering a HUD update.

@Larkinabout Larkinabout added this to the 1.3.0 milestone Feb 18, 2023
@Larkinabout
Copy link
Owner

Moving to the Token Action HUD Core repos as the issue needs to be resolved there.

@Larkinabout Larkinabout transferred this issue from Larkinabout/fvtt-token-action-hud-dnd5e Feb 18, 2023
Larkinabout added a commit that referenced this issue Feb 20, 2023
- #64. #65, #67: Add timer and flags to avoid HUD updating multiple
  times at once and creating duplicate actions.
@Larkinabout
Copy link
Owner

This should now be fixed in Token Action HUD Core 1.2.2. I'll leave this issue open for a little while for feedback.

@Aragith
Copy link

Aragith commented Feb 20, 2023

It looks like, so far, the element replication has been addressed. However, now I cannot seem to add a ranged option for thrown weapons.

@Larkinabout
Copy link
Owner

Fixed in Token Action HUD Core 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants