-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] travis: Add PyPi deploy #6
Conversation
Current coverage is 100% (diff: 100%)@@ master #6 diff @@
===================================
Files 4 4
Lines 85 137 +52
Methods 0 0
Messages 0 0
Branches 3 6 +3
===================================
+ Hits 85 137 +52
Misses 0 0
Partials 0 0
|
ebc8257
to
f48aa20
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 LGTM minus a question I had about a variable.
- LINT_CHECK="0" | ||
- DOCS="0" | ||
- PYPI="0" | ||
- secure: "m5bpPi2ZU6vNchdCjGrj75NR2AWeGHTdPzpU7GIkintcaNA/wX9HPly7NsC91bZ0M3gzuY+xcJuUhKCTlHmDTnr2owP9bS21UFl6sd+WX1SfWcJibrcBdYVtqi3iJphoRnGFcPVq6KAx2s3IcitZivE++PdyLNac1gQgOzcshYcFEenVT+Q1kemPf8uC7bYZHrm75o6ukoeJXA1ydMxBk479YLtWkx6GefMJdCE4vN73SKUakuwZSgBD6s3EqntBWtf6jvFrIKnq0taGe8bSu0GMgX2BwBRrDkLzk0bKRH8B4cmb1MJ/0wCHboKculPVNNrqsYJ7tPlExUnLloPUUKXQKQHNJkaNV77fI8OrRyqu/jZW2IMsN/VgPHrzofmewM++Zd8IRugBjAJAC5BPl2nZQNn4QGoS7rDCjhG6phL+0YyM4wCdzcLBPrqJ4p1hDE6s2Hw6pSmDRie8lKHVMmxasbVUi/SP4lSUMzE/0UeRbTlWAoSA4ogIhWhOUy9P46tfzm2PhRjckx2MCH9Z4fPTWA44lK1SjwPRxBjC4o5Cj6fa4B5PRMSz+DaXyuB0uW0OB7pN9aLozkv7gKemv4GEeid8IWyHl7RwRv/OsCdLJ26+mJ/vqpei33ZxzhGHKjFxechCLa5n3SJm8jGAZicWv3xbiWyxR2SHsJH7PIw=" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not certain in what context this base64 is used but I'm assuming having it in the repo isn't a security risk? Just going off the name :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the PyPi password, encrypted per Travis docs - https://docs.travis-ci.com/user/encryption-keys/
I put a comment in the sample file showing how to generate - https://github.com/LasLabs/python-quality-tools/blob/master/sample_files/.travis.yml#L25
The travis
binary is a Ruby gem, so it's just gem install travis
Don't merge this - I need a test branch |
* Adds compatibility for auto-deploy as introduced in LasLabs/python-quality-tools#3
f48aa20
to
7bcb8e1
Compare
7bcb8e1
to
2f05480
Compare
Changes Unknown when pulling 2f05480 on feature/master/travis-pypi into ** on master**. |
Adds compatibility for auto-deploy as introduced in LasLabs/python-quality-tools#3