composer dependency analyser
#140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LastDragon-ru
force-pushed
the
ci/composer-dependency-analyser
branch
from
0c0667f
to
9acd73a
Compare
LastDragon-ru
force-pushed
the
ci/composer-dependency-analyser
branch
from
9acd73a
to
98bd58b
Compare
janedbal
reviewed
Mar 15, 2024
| // Assertions | ||
| assert(isset($this) && $this instanceof Initializer); | ||
| assert(isset($options) && $options instanceof CliOptions); | ||
| assert(isset($composerJson) && $composerJson instanceof ComposerJson); |
There was a problem hiding this comment.
All this wont be available after shipmonk-rnd/composer-dependency-analyser#102. Instead, you can:
- get
$cwdjust bygetcwd() - get the given path to
composer.jsonbygetopt('', ['composer-json:'])['composer-json'] - parse autoload paths the same way you do for
exclude-from-classmap- I'll think if I cannot add better support to override dev paths in this config so that you would not need to do
disableComposerAutoloadPathScan(and re-adding those byaddPathToScan).
- I'll think if I cannot add better support to override dev paths in this config so that you would not need to do
There was a problem hiding this comment.
Basically any class or method not mentioned in readme (which is just Configuration and ErrorType) is not considered public API (as CDA is mainly a CI tool) and may change in future, so it is better to avoid using those.
There was a problem hiding this comment.
Yep, agree. But I will merge it as is (because need it for #117) and update a bit later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to check dependencies.