Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better communicate Snow needs to be implemented in all pages #122

Closed
weizman opened this issue Jul 16, 2023 · 1 comment
Closed

Better communicate Snow needs to be implemented in all pages #122

weizman opened this issue Jul 16, 2023 · 1 comment

Comments

@weizman
Copy link
Member

weizman commented Jul 16, 2023

CTX #109 (comment):

What would also help is if we communicate the importance of implementing Snow in all same origin pages, this should help with issues such as #73

CTX 2 #73 (comment):

#128 fixes some problems from #124, bringing us closer to a solution for this problem.
Next step would be to address #122, so that it's clear for the users what they need to do to protect themselves fully against #73

Bottom line:

Past PRs make it so that exploiting #73 isn't possible if ONE of the following TWO conditions is met:

  1. Snow is correctly implemented in ALL same origin HTML pages served by the server (including 404 and such).
  2. Pages correctly allow frame-src CSP only to same-origin or well trusted origins. allowing untrusted cross origin iframes allows Snow can be bypassed with ...data: URI #73 to exist when condition (1) isn't met.
    • Note: is that true when taking open() into consideration too? Need to research...

This ⬆️ needs to be correctly communicated for #73 to be considered addressed.

@weizman
Copy link
Member Author

weizman commented Aug 3, 2023

#135 solves this mainly by communicating section 1 (section 2 however is less relevant actually)

@weizman weizman closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant