Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

axPageFade: resolve implicit jQuery dependency #180

Closed
x1B opened this issue Apr 21, 2015 · 3 comments
Closed

axPageFade: resolve implicit jQuery dependency #180

x1B opened this issue Apr 21, 2015 · 3 comments

Comments

@x1B
Copy link
Member

x1B commented Apr 21, 2015

The axPageFade directive uses element.fadeOut without requiring jQuery explicitly.
We should remove the page fade directive from LaxarJS core to avoid this problem (possibly move it to UiKit).

@x1B x1B added this to the v1.0.0 milestone Apr 21, 2015
@x1B x1B added bug and removed in progress labels Apr 21, 2015
@x1B x1B self-assigned this Apr 21, 2015
@x1B x1B added in progress and removed assigned labels Apr 23, 2015
@x1B
Copy link
Member Author

x1B commented Apr 23, 2015

This bug occurs only on master.

@x1B x1B added the breaking label Apr 23, 2015
@x1B
Copy link
Member Author

x1B commented Apr 23, 2015

Breaking Change

The directive axPageFade has been removed from LaxarJS core. Its purpose was to visually hide pages during load (initial load as well as navigation), so that stepwise assembly (rendering -> events -> rendering) of the page is not noticeable.

This behavior is sometimes useful, especially for applications that are very complex, but also highly application specific. Because the old directive required jQuery to be available (not just jqLite), it has been removed from core.

A opt-in replacement with usage instructions is provided with LaxarJS/laxar-uikit#113.

x1B added a commit that referenced this issue Apr 23, 2015
* feature/180-remove-page-fade-directive:
  (#180) directives: removed `axPageFade` directive
@x1B x1B added enhancement and removed bug labels Apr 23, 2015
@x1B
Copy link
Member Author

x1B commented Apr 23, 2015

Availability

Implemented on master (v1.0.0).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants