Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config option DisplayModeBar is not adhered to #34

Closed
EuanKirkhope opened this issue Aug 5, 2020 · 4 comments · Fixed by #35
Closed

Config option DisplayModeBar is not adhered to #34

EuanKirkhope opened this issue Aug 5, 2020 · 4 comments · Fixed by #35
Assignees
Labels
bug Something isn't working

Comments

@EuanKirkhope
Copy link

The mode bar will always appear in hover mode (the default action).

    Config config = new Config
    {
        DisplayModeBar = ConfigLib.DisplayModeBarEnum.True
    };

Setting to False has no effect.

https://plotly.com/javascript/configuration-options/#never-display-the-modebar

Changing Config.cs DisplayModeBar def to below fixes issue:

public bool? DisplayModeBar { get; set; }
@sean-mcl sean-mcl self-assigned this Aug 5, 2020
@sean-mcl sean-mcl added the bug Something isn't working label Aug 5, 2020
@sean-mcl
Copy link
Collaborator

sean-mcl commented Aug 5, 2020

Hi,

thank you for the hint. I'll try to fix it. 👍

@sean-mcl
Copy link
Collaborator

sean-mcl commented Aug 5, 2020

Just took a look at the whole thing.
We can't use bools here because there are three different possibilities: hover, true, false. According to the (plotly scheme), this is an enum.

He recognizes "true" with quotes as valid but ignores "false". According to the plotly scheme these are both valid values.

I will forward the problem to the plotly team.

@EuanKirkhope
Copy link
Author

Yeah I see that in the code. Defining as bool works though, but you can't change back to hover after defining the item. If it is left undefined its hover, and if you define the variable its either on or off. I don't think many would want to dynamically change back from either behaviours to hover. Will be good to see what the Plotly folks say.

Very nice wrapper Btw. Sure beats my method which was to define the json as as string and send to plotly through the interop. Thankyou!

sean-mcl added a commit that referenced this issue Aug 6, 2020
@sean-mcl
Copy link
Collaborator

sean-mcl commented Aug 6, 2020

Hi,
should work now in v1.1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants