Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Fix MyOFT test in OFT example #399

Merged
merged 2 commits into from
Feb 13, 2024
Merged

🪲 Fix MyOFT test in OFT example #399

merged 2 commits into from
Feb 13, 2024

Conversation

janjakubnanista
Copy link
Contributor

In this PR

  • The test for MyOFT in OFT example was not actually testing the OFT. We still need a derived contract that exposes the mint function for this test to work but this derived contract should use the MyOFT contract

@janjakubnanista janjakubnanista merged commit c8f1739 into main Feb 13, 2024
5 checks passed
@janjakubnanista janjakubnanista deleted the example-fixes branch February 13, 2024 18:17
@actuallymentor actuallymentor mentioned this pull request Feb 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryandgoulding ryandgoulding ryandgoulding approved these changes

@St0rmBr3w St0rmBr3w Awaiting requested review from St0rmBr3w

@kushdave95 kushdave95 Awaiting requested review from kushdave95

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janjakubnanista @ryandgoulding