New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using whoiser with 'use strict' fails #99

Merged

AndreiIgna merged 1 commit into LayeredStudio:master from sduc:master

Apr 21, 2023

Contributor

sduc commented Apr 19, 2023

Q	A
Bug fix?	yes
New feature?	no
Deprecations?	no
Tickets
License	MIT

Imported the library in a code which enforce use strict. Without this PR I get the following error:

ReferenceError: key is not defined
    at /usr/app/dist/index.js:127446:16
    at Array.forEach (<anonymous>)
    at parseSimpleWhois (/usr/app/dist/index.js:127427:61)
    at whoisTld (/usr/app/dist/index.js:127876:20)
    at async whoisDomain (/usr/app/dist/index.js:127900:21)

You can ignore the line numbers since it was bundled with esbuild.


          Update parsers.js

a8588b2

Member

AndreiIgna commented Apr 21, 2023

hey @sduc thanks for fixing this. It will included in the next release on npm, in a few hours

AndreiIgna merged commit 24a72fd into LayeredStudio:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet