Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Check total stake before calculating chunk length #225

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Fix: Check total stake before calculating chunk length #225

merged 1 commit into from
Feb 2, 2024

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

If totalStake is 0, ValidateChunkLength will panic with division by 0 exception

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review January 30, 2024 23:25
@ian-shim ian-shim merged commit 2835e89 into Layr-Labs:master Feb 2, 2024
4 of 5 checks passed
bxue-l2 pushed a commit to bxue-l2/eigenda that referenced this pull request Feb 2, 2024
@ian-shim
Fix: Check total stake before calculating chunk length (Layr-Labs#225)
41fd3c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mooselumph mooselumph mooselumph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ian-shim @mooselumph