Update metrics not to double count blob failures #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
failure-retry-metrics
branch
from
60fcff5
to
8c39a4f
Compare
jianoaix
approved these changes
Apr 2, 2024
| @@ -165,7 +165,8 @@ type BlobStore interface { | |||
| // GetBlobMetadata returns a blob metadata given a metadata key | |||
| GetBlobMetadata(ctx context.Context, blobKey BlobKey) (*BlobMetadata, error) | |||
| // HandleBlobFailure handles a blob failure by either incrementing the retry count or marking the blob as failed | |||
| HandleBlobFailure(ctx context.Context, metadata *BlobMetadata, maxRetry uint) error | |||
| // Returns a boolean indicating whether the blob should be retried and an error | |||
There was a problem hiding this comment.
nit: It may be fine to omit subject but may need to keep it consistent with methods above
There was a problem hiding this comment.
Can you clarify the suggestion here? This is consistent with methods above L141, L144
There was a problem hiding this comment.
I see, there is "HandleBlobFailure handles" at L167
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Right now, it's reporting retryable failures as
Failedblobs. It should only be reported if it permanently failed dispersal.Checks