Detect Fireblocks http timeout error #448
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The http client does not wrap the
error
but concatenates error strings, which doesn't let theerr
unwrap.All errors from the client will be
url.Error
type which supportsTimeout()
method to tell whether the request timed out.This PR uses this method to tell whether the request timed out, instead of unwrapping the error using
errors.Is
.See playground here
Checks