Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6/N] Chunk encoding optimization: Disperser/Retriever support for new chunk encoding #650

Merged
merged 8 commits into from
Jul 26, 2024
Merged

[6/N] Chunk encoding optimization: Disperser/Retriever support for new chunk encoding #650

merged 8 commits into from
Jul 26, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Jul 19, 2024 •
edited
Loading

Why are these changes needed?

  • Disperser to create chunks in new encoding format (with flag guarded)
  • Retriever to decode the chunks based on encoding format

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from bxue-l2 July 19, 2024 21:50
bxue-l2
bxue-l2 approved these changes Jul 26, 2024
View reviewed changes
Copy link
Contributor

@bxue-l2 bxue-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@bxue-l2
Copy link
Contributor

bxue-l2 commented Jul 26, 2024

the e2e test failed. Looks like a timeout, do you see a problem there?

@jianoaix
Copy link
Contributor Author

the e2e test failed. Looks like a timeout, do you see a problem there?

this PR has no effect (until the flag is enabled). Retrying...

@jianoaix jianoaix merged commit 3d9f547 into Layr-Labs:master Jul 26, 2024
6 checks passed
pschork pushed a commit that referenced this pull request Jul 28, 2024
@jianoaix @pschork
[6/N] Chunk encoding optimization: Disperser/Retriever support for ne…
8b4b82c 
…w chunk encoding (#650)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxue-l2 bxue-l2 bxue-l2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @bxue-l2