[batcher] Recover blob state #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ian-shim
force-pushed
the
batcher-blobs-cleanup-at-init
branch
from
48579c4
to
2b9b2a5
Compare
ian-shim
force-pushed
the
batcher-blobs-cleanup-at-init
branch
from
2b9b2a5
to
ea286ba
Compare
cody-littley
approved these changes
Jul 30, 2024
mooselumph
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
If batcher crashes in the middle of processing blobs, it could leave blob state stale, i.e. blobs in
DISPERSINGstate may never get processed.This PR adds a
RecoverStatemethod that triggers at batcher initialization and updates all blobs inDISPERSINGstate intoPROCESSING, so that they can be retried.Checks