Configuration for new generator functionality. #674
Conversation
Signed-off-by: Cody Littley <cody@eigenlabs.org>
| envPrefix = "TRAFFIC_GENERATOR" | ||
| ) | ||
|
|
||
| var ( |
There was a problem hiding this comment.
Instead of listing flags for dependent packages again, we could import the flags directly like here
| ) | ||
|
|
||
| // Config configures a traffic generator. | ||
| type Config struct { |
There was a problem hiding this comment.
We could reuse the configs from dependencies directly like we do here
Signed-off-by: Cody Littley <cody@eigenlabs.org>
tools/traffic/config/config.go
Outdated
| TheGraphConfig *thegraph.Config | ||
|
|
||
| // Configuration for the EigenDA client. | ||
| EigenDaClientConfig *clients.EigenDAClientConfig |
There was a problem hiding this comment.
Fixed.
In java, the prevailing style is to capitalize only the first letter of an acronym. I find the java pattern ugly, but muscle memory takes time to retrain. 🙃
| @@ -0,0 +1,262 @@ | |||
| package config | |||
There was a problem hiding this comment.
are these moved from /tools/traffic/flags.go? or are these being added in addition to the existing ones?
There was a problem hiding this comment.
In the short term, the new flags.go file will duplicate the original file in the master branch, but will not be used for anything. When the rest of the code from this branch merges, the new flags.go will entirely replace the old one.
I'm merging this way so that I can split off the config changes into a stand alone PR. It can't replace the old flags because it's not fully backwards compatible.
Signed-off-by: Cody Littley <cody@eigenlabs.org>
Why are these changes needed?
This code was broken off of another PR that got too large: #666
This PR contains configuration for the new generator functionality. It is not utilized in this branch, but it will be utilized once the rest of the code merges.
Checks