Enable minibatcher #701
Closed
Enable minibatcher #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pschork
force-pushed
the
pschork/minibatch_enabled
branch
from
9fdb219
to
98163f5
Compare
ian-shim
reviewed
Aug 20, 2024
pschork
force-pushed
the
pschork/minibatch_enabled
branch
5 times, most recently
from
111409f
to
2cbfeed
Compare
ian-shim
reviewed
Aug 21, 2024
Comment on lines
-38
to
-39
| ChainState core.IndexedChainState | ||
| AssignmentCoordinator core.AssignmentCoordinator |
There was a problem hiding this comment.
thanks for cleaning this up!
|
|
||
| o.finalizer.Start(ctx) | ||
|
|
||
| go func() { |
There was a problem hiding this comment.
Should we keep this loop in minibatcher (and Start method)?
Looks like we moved it here to have signalLiveness interweaved in the loop, but signaling liveness from the high level component seems sufficient
There was a problem hiding this comment.
Don't we need to signalLiveness on some sort of reoccurring loop where work is being done?
pschork
force-pushed
the
pschork/minibatch_enabled
branch
from
16f1f3b
to
1458f9c
Compare
Refactor batcher/minibatcher creation to use generic interface Fix integration test Fix tests Update batcher interface type cast Move minibatcher tablename check to earlier init phase Make minibatcher table name optional Add info output at startup Lint Remove log output Rename MinibatchStore to Batchstore Remove generic batch/minibatcher interface Add orchestrator abstraction Add metrics Add finalizer Refactor and consolidate encoding client/streamer init Revert batcher to original Move minibatcher branch logic to main Move finalizer, encodingstreamer, chain state, assignment mgr into orchestrator Add batchConfirmer to orchestrator Move signalLiveness into orchestrator Add transactionMgr startup to orchestrator Lint Lint Lint Lint
pschork
force-pushed
the
pschork/minibatch_enabled
branch
from
1458f9c
to
0b5e119
Compare
pschork
force-pushed
the
pschork/minibatch_enabled
branch
from
bc881cb
to
67d26ec
Compare
pschork
force-pushed
the
pschork/minibatch_enabled
branch
from
046755a
to
4497dfc
Compare
|
Abandoned. RIP Minibatcher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Checks