Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3/N][zero serialization] Make Encoder produce and pass chunks in desired format #735

Merged
merged 2 commits into from
Aug 31, 2024
Merged

[3/N][zero serialization] Make Encoder produce and pass chunks in desired format #735

merged 2 commits into from
Aug 31, 2024

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Aug 29, 2024 •
edited
Loading

Why are these changes needed?

This plumbs the chunk encoding format from Encoder, and make it produce and pass chunks in that desired format.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested a review from bxue-l2 August 29, 2024 20:12
bxue-l2
bxue-l2 approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@bxue-l2 bxue-l2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jianoaix jianoaix merged commit 5692cac into Layr-Labs:master Aug 31, 2024
6 checks passed
@jianoaix jianoaix mentioned this pull request Sep 1, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxue-l2 bxue-l2 bxue-l2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @bxue-l2