Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker-publish-release docker bake #772

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

pschork
Copy link
Contributor

@pschork pschork commented Sep 24, 2024

Why are these changes needed?

When we fixed the devops docker builds, we added REGISTRY variable in docker-bake, but we did not separate the registry URL from the repo path which broke our push config.

Checks

  • I've made sure the lint is passing in this PR.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@pschork pschork merged commit e30979a into master Sep 24, 2024
10 checks passed
pschork added a commit that referenced this pull request Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants