This repository has been archived by the owner on May 26, 2020. It is now read-only.
v 0.2.0 request #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't know how to use composer and don't want to waste time with it right now.
autoload.php was required but not included which was... frustrating. The Client class had required an outside library, "GuzzleHttp". Instead now we just rely on php's curl extension which is much more likely to already be setup on an average users system. In addition there is a working version of the test.php script which will be cleaned up and explained in the next push.
…d pushMetrics function Added a detailed readme that covers the concept of the push gateway and why its needed here. Included an example_config for a prometheus server to pull from the push gateway. included @timeZynks Histogram.php and relevant code into the fork. Split the test script into a test for each metric type to offer more guidance. Added the pushMetrics() function which returns the ability for the client to push the serialized data to a push gateway.
|
I'll update the composer and gitignore so this can be merged. |
|
any news on this? |
|
This would be great. Just found this Repo and now found a Readme to go with it. |
|
Sorry about the long delay, but this has been merged. I added back the composer stuff and a couple other things. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A branch from timeZynk that gives clearer instructions in the readme on how to use the client for new users while providing a counter and histogram test script.
In addition this restores the ability for the client to push to a pushgateway that timeZynk had removed.
It also provides an example config for the prometheus server to show how to pull from a pushgateway.
I would update the composer files but i don't know composer.