Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added parameter seed to the widget. #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Keyeoh
Copy link

@Keyeoh Keyeoh commented Oct 10, 2017

I have added a 'seed' parameter to the wordcloud2 function. If it is NULL,
the function still works as expected. In case it does not, the WordCloud
JS function will use a special random generator initialized from a given
seed. This can be useful whenever you want to recreate the same word cloud.

I have borrowed the code for the random number generator from:

https://stackoverflow.com/a/19303725/2061043

I have added a 'seed' parameter to the wordcloud2 function. If it is NULL,
the function still works as expected. In case it does not, the WordCloud
JS function will use a special random generator initialized from a given
seed. This can be useful whenever you want to recreate the same word cloud.

I have borrowed the code for the random number generator from:

https://stackoverflow.com/a/19303725/2061043
@Lchiffon
Copy link
Owner

Hi Keyeoh, thanks for your PR, this feature should be added in wordcloud2.

However, I have installed your version but it doesn't works.

devtools::install_github("Keyeoh/wordcloud2@set_seed")
library(wordcloud2)
wordcloud2(demoFreq,seed = 123)
wordcloud2(demoFreq,seed = NULL)

There are errors in the web console:

image

@Keyeoh
Copy link
Author

Keyeoh commented Oct 16, 2017

Hi,

Javascript is certainly not my strong point, but I have tried to fix those messages. I think I have succesfully managed to do it, although there might be some loose points I could not be aware of.

It should be all fixed in the last commit.

Regards,
Gus.

@Lchiffon
Copy link
Owner

It looks good so far and thanks for your pull request.

@Lchiffon
Copy link
Owner

Lchiffon commented Oct 18, 2017

Hi @Keyeoh

Well, I found it doesn't work in letterCloud function:

letterCloud(demoFreq,"R",seed = 123)
letterCloud(demoFreq,"R",seed = 123)

Don't worry, I will try to find some solutions, too~

@MatthieuStigler
Copy link

Jumping on an old thread, I was looking for this feature, and found it here, thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants