Clean up for release #131
Merged
Clean up for release #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rjmurillo
commented
Apr 19, 2017
•
rjmurillo
commented
- Dependency updates
- Castle.Core
- BenchmarkDotNet
- C# code analysis
- Code clean up
- Clean up code according to the code analysis rules
- Add additional tests
- Add tests where needed to improve coverage
rjmurillo
force-pushed
the
feature/Cleanup
branch
from
521cdb4
to
ce5e89c
Compare
- Remove additional package sources (to reduce restore time / noise) - Prevent user from disabling nuget.org and prevent restoration
- File now includes VS2017 image - msbuild and vstest use Dev15 tools - Nuget restore explicitly uses version installed to `.tools` folder after executing `init.ps1` - Artifact publish settings configured in file using secure values from appveyor.com - `Performance` test category added to list of test exclusions - Parallel build execution disabled to avoid build double-writes issues
Update non-shipping ruleset Suppress CA1014, CA1707, and CA1709 because it's too noisy for our test style.
Projects: Linq, Mapper, Core.Tests, Mocks, Core, Soap, Rest
rjmurillo
force-pushed
the
feature/Cleanup
branch
from
9648e7e
to
286086f
Compare
rjmurillo
force-pushed
the
feature/Cleanup
branch
from
286086f
to
d482b57
Compare
Integration tests and test common
Rather than hard coding a value in the predicate, the constant reference name is used.
Work item types are now kept in a HashSet<string> to reduce duplication when emitting multiple types in WIQL.
Model specifies a WIT that does not exist in the system. Updating to use an existing WIT.
Tests for Core fields are broken up into three types: - Core fields with no known differences - Core fields with identities - Core fields with date/time The core fields with no known differences make regular equality assertions between work items produced by each client. It is expected that there are no known differences. The core fields with identities may have differences between each client: SOAP will produce an identity in either the "Display Name" or "Display Name <account>" depending on ambiguity. REST always produces the latter. Identities are pushed through a helper class (`IdentityFieldValue`) to parse out the different pieces and compare the resulting `DisplayName` for equality. It is expected that there are no known differences. The core fields with date/time have differences: SOAP converts the value to the offset provided in the user's preferences, while REST always sends the value as UTC. Each date value is returned and SOAP values are converted to UTC via the built-in method on the `DateTime` type for equality. It is expected that there are no known differences.
Remove filters for `Benchmark` and `Performance` and add filters for `SOAP` and `REST`. This will lengthen a CI build as it will execute benchmarks. Estimated delay: 5-10 minutes. Statistics are printed in the output for the test, and artifacts are produced in the test output folder.
Remove references to Qwiq.Core and Qwiq.Mocks. Project only contains classes required for BenchmarkDotNet
Remove LegacyJit since we are running 4.7 with Ryu in production
Benchmark created LOTS of work items, which effectively began to test the CPU cache on the machine rather than the actual mapping code. This is now restricted to creating a single item and performing mapping against it.
The test that wraps the benchmark test now verifies two mapped properties on each model: one with spaces, one without.
|
@pelavall This is ready now. I will create a new branch to track the changes we discussed for IMS |
This was referenced Apr 20, 2017
Closed
pelavall
approved these changes
Apr 21, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.